Skip to content

Add empty dependencies value to ECS Deploy job

Etienne Baqué requested to merge 228674-no-dependencies-on-deploy-ecs into master

What does this MR do?

This is a small follow-up of this other MR: !36741 (comment 378783022)

Manual testing

After pushing these changes here, I referenced this updated ECS template into the .gitlab-ci.yml file of a sample project: https://gitlab.com/ebaque/rails-minimal/-/blob/deploy-to-ecs/.gitlab-ci.yml

This pipeline ran then on the sample project: https://gitlab.com/ebaque/rails-minimal/-/pipelines/193470807

The SHA of the new Docker image built (in this job) matches the SHA of the Docker image deployed onto the targetted EC2 instance:

SHA is: 5102e000596c0084ad4f02d7c1f01d045e04ebfd

Screenshot_from_2020-09-23_13-40-08

Screenshot_from_2020-09-23_13-35-44

In the review-ecs job, the new version of the ECS task definition, hello-review-task-definition:19, matches the one in the EC2 dashboard:

Screenshot_from_2020-09-23_13-44-05

Screenshot_from_2020-09-23_13-44-52

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #228674 (closed)

Edited by Etienne Baqué

Merge request reports