Skip to content

Verbiage tweaks for SAST config MRs

rossfuhrman requested to merge rf-sast-mr-verbiage into master

What does this MR do?

This adds clarification to the difference between adding SAST when no CI has been set up before, versus when ADO has been running.

This work is being done in support of this issue, and specifically this linked comment: #223878 (comment 378642977)

Note: We will be moving away from this REST approach with this upcoming issue: BE implementation - Convert Rest API to GraphQL mutation for MR Creation flow

Screenshots

SAST commit message and description >>

Screen_Shot_2020-07-14_at_9.29.09_AM

SAST .gitlab-ci.yml commit >>

Screen_Shot_2020-07-14_at_9.29.21_AM

ADO commit message and description >>

Screen_Shot_2020-07-14_at_9.30.41_AM

ADO .gitlab-ci.yml commit >>

Screen_Shot_2020-07-14_at_9.30.57_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by rossfuhrman

Merge request reports