Skip to content

Improve parallel persistance for audit event author_name

Max Woolf requested to merge 220318-author_name_parallel_callback into master

What does this MR do?

On verification of #220318 (closed) we discovered that some audit events were not created with author_name populated correctly.

This approach saves the author_name as an AR callback (similar to the approach agreed in !36198 (merged)) making it much more unlikely that this could happen in future.

It also brings consistency to the approach we're going to take in the parallel persistence phase of refactoring AuditEvent.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Mentions #220318 (closed)

Edited by Max Woolf

Merge request reports