Skip to content

Page title is `.editorconfig` when the Web IDE is loaded from an MR

Himanshu Kapoor requested to merge 223928-page-title-editorconfig into master

What does this MR do?

  • Issue: #223928 (closed): When the Web IDE is loaded from an MR, the page title is .editorconfig. This MR fixes the issue.
  • Also cleanup (in separate commit: !36783 (91cb4f63)) the tests in file_spec.js to return promises instead of using the done and done.fail functions.

It would be helpful to review the MR commit by commit.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Himanshu Kapoor

Merge request reports