Update $gray-900 to match gitlab-ui palette
What does this MR do?
Closes #228727 (closed)
Didn't add a changelog because this change is basically imperceptible.
Screenshots
Before | After |
---|---|
#2e2e2e |
#303030 |
Merge request reports
Activity
changed milestone to %13.2
2 Warnings Please add a throughput label to this merge request. You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~”backstage”, ~”tooling”, ~”tooling::pipelines”, ~”tooling::workflow”, ~”documentation”, ~”QA” labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 36778 "Update $gray-900 to match gitlab-ui palette"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 36778 "Update $gray-900 to match gitlab-ui palette"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Tom Quirk ( @tomquirk
) (UTC+9.5, 0.5 hours behind@psimyn
)Olena HK. ( @ohoral
) (UTC+3, 7 hours behind@psimyn
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 85103270 and 96942209
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.18 MB 4.18 MB - 0.0 % mainChunk 3.29 MB 3.29 MB - 0.0 %
Note: We do not have exact data for 85103270. So we have used data from: 42b544df.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Olena Horal-Koretska
@ohoral can you please maintainerify?
assigned to @ohoral
- Resolved by Olena Horal-Koretska
@jeldergl this color didn't require any other updates, right?
mentioned in commit 30b1bee0
added workflowstaging label
added workflowproduction label and removed workflowstaging label