Resolve "Investigate duplicate use of shorcuts-tree"
What does this MR do?
Removes the shortcut g f
as a navigation shortcut from items where it will not work and is duplicate.
This shortcut was intended for a shortcut to project repo file tree only.
More analysis:
-
.shortcuts-tree
binds tog f
as seen https://gitlab.com/gitlab-org/gitlab/-/blob/31a1c9975c2ecb748c34ab5ea1bb602f72de3171/app/assets/javascripts/behaviors/shortcuts/shortcuts_navigation.js#L12 -
findAndFollowLink
is executed which follows thehref
of the first selector found. - Only valid usage where the shortcuts follows the
href
correctly can be found https://gitlab.com/gitlab-org/gitlab/-/blob/7aa31aa23341c247e2537bf52e8d39d0d247d029/app/views/layouts/nav/sidebar/_project.html.haml#L40.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #219122
Edited by Doug Stull