Skip to content

Resolve "Investigate duplicate use of shorcuts-tree"

What does this MR do?

Removes the shortcut g f as a navigation shortcut from items where it will not work and is duplicate.

This shortcut was intended for a shortcut to project repo file tree only.

More analysis:

  1. .shortcuts-tree binds to g f as seen https://gitlab.com/gitlab-org/gitlab/-/blob/31a1c9975c2ecb748c34ab5ea1bb602f72de3171/app/assets/javascripts/behaviors/shortcuts/shortcuts_navigation.js#L12
  2. findAndFollowLink is executed which follows the href of the first selector found.
  3. Only valid usage where the shortcuts follows the href correctly can be found https://gitlab.com/gitlab-org/gitlab/-/blob/7aa31aa23341c247e2537bf52e8d39d0d247d029/app/views/layouts/nav/sidebar/_project.html.haml#L40.

Screenshots

Shortcut working

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #219122

Edited by Doug Stull

Merge request reports