Remove an obsolete TODO comment
What does this MR do?
This was handled in !34377 (merged), but in a different way than this comment envisaged, so I didn't touch this line or see the comment.
Merge request reports
Activity
changed milestone to %13.2
added groupscalability typemaintenance labels
mentioned in merge request !36546 (merged)
1 Warning You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~”backstage”, ~”tooling”, ~”tooling::pipelines”, ~”tooling::workflow”, ~”documentation”, ~”QA” labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 36696 "Remove an obsolete TODO comment"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 36696 "Remove an obsolete TODO comment"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Aakriti Gupta ( @aakriti.gupta
) (UTC+2, 1 hour ahead@smcgivern
)Igor Drozdov ( @igor.drozdov
) (UTC+3, 2 hours ahead@smcgivern
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖@fabiopitino could you take a look at this tiny change, please?
assigned to @fabiopitino and unassigned @smcgivern
Thanks @smcgivern! MWPS set
enabled an automatic merge when the pipeline for 32454051 succeeds
mentioned in commit ea35307c
mentioned in issue gitlab-com/gl-infra/scalability#477
added workflowstaging label
added workflowproduction label and removed workflowstaging label