Skip to content

Fix difference between button sizes

Savas Vedova requested to merge 225368-fix-nav-buttons-sizes into master

What does this MR do?

Related to #225368 (closed).

Fixes the difference between the button sizes in the instance level security dashboard. The issue was happening because the icon size is bigger than the text and it pushes the button height. Adding a parent div with display: flex; solved the issue as both buttons are now filling up the whole vertical space.

Screenshots

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports