Skip to content

Use existing-user language in reconfirmation email

Dan Jensen requested to merge 219558-improve-confirmation-email-language into master

What does this MR do?

To resolve a security issue, we sent re-confirmation emails to many existing users of gitlab.com. Unfortunately, most of those emails said "Thanks for signing up to GitLab!" That spooked users, because they had not just signed up (example).

This causes existing-user language to be used in Devise confirmation emails when the user appears to be in need of re-confirmation. See https://gitlab.com/gitlab-org/gitlab/-/issues/220756#note_377459554.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #219558

Edited by Dan Jensen

Merge request reports