Add MR approval status column to the compliance dashboard
What does this MR do?
This MR will close off #217939 (closed) and display the approval status from !36824 (merged) on the compliance dashboard.
The MR adds a new column to the dashboard and a new ApprovalStatus
component which functions in a similar fashion to the existing PipelineStatus
component.
The checks are:
- MR authors are not allowed to approve MRs
- MR committers are not allowed to approve MRs
- The number of required approvers is >= 2
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- Navigate to
groups/[GROUP]/-/security/compliance_dashboard
- Create and merge MR's for different projects; which pass or fail the checks listed above
- Check that the correct icon is displayed for each, with the correct tooltip and the icon links to the
separation of duties
documentation
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Related #217939 (closed)
Edited by Robert Hunt