Skip to content

Add MR approval status column to the compliance dashboard

What does this MR do?

This MR will close off #217939 (closed) and display the approval status from !36824 (merged) on the compliance dashboard.

The MR adds a new column to the dashboard and a new ApprovalStatus component which functions in a similar fashion to the existing PipelineStatus component.

The checks are:

  • MR authors are not allowed to approve MRs
  • MR committers are not allowed to approve MRs
  • The number of required approvers is >= 2
Status Icon Description
[empty] The Merge Request approval status is unknown
failed Screenshot_2020-07-16_at_13.42.39 The Merge Request does not comply with any of the above criteria
warning Screenshot_2020-07-16_at_13.44.01 The Merge Request complies with some of the above criteria
success Screenshot_2020-07-16_at_13.44.09 The Merge Request complies with all of the above criteria

Screenshots

Screenshot_2020-07-16_at_14.07.00

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

  1. Navigate to groups/[GROUP]/-/security/compliance_dashboard
  2. Create and merge MR's for different projects; which pass or fail the checks listed above
  3. Check that the correct icon is displayed for each, with the correct tooltip and the icon links to the separation of duties documentation

Related #217939 (closed)

Edited by Robert Hunt

Merge request reports