Skip to content

Don’t show close icon on flash warning

Alex Buijs requested to merge remove-close-button-from-flash-warning into master

What does this MR do?

Summary

Flash warnings show a close button, despite being in-dismissible.

Steps to reproduce

Sign up with a new account on GitLab.com. After signing up, a banner will be shown as in the screenshot.

What is the current bug behavior?

A close button is shown and clicking it does nothing.

What is the expected correct behavior?

The close button should not be shown.

Related to #34562 (closed)

Screenshots

before after
Screen_Shot_2020-07-10_at_16.50.25 Screen_Shot_2020-07-10_at_16.49.22

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports