Skip to content

Split secret detection into default and non-default branches jobs

Zach Rice requested to merge 36860-secret-detection-branch-job into master

What does this MR do?

This MR changes the default secret_detection job to scan commits on non-default branches as that is the common case. Users will be pushing up commits on feature branches and those commits should be scanned for secrets as they get pushed. The secret_detection_default_branch job runs as the old secret_detection job did -- it scans files at the HEAD of the default branch. Sample pipeline: https://gitlab.com/zrice/demo-historic-secrets/-/pipelines/165264461

Screenshots

Secret Detection Branch job: Screen_Shot_2020-07-09_at_7.30.02_PM

Results: Screen_Shot_2020-07-09_at_7.31.37_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zach Rice

Merge request reports