Skip to content

Refactor target_details from AuditEvent details

Max Woolf requested to merge 220325-target_details_refactor into master

What does this MR do?

This MR adds a target_details column to AuditEvent and persists the value of details[:target_details] to the target_details column when an AuditEvent is created (or updated, not that it should ever be updated as AuditEvents should be immutable.)

Database

Migrate

== 20200710120500 AddTargetDetailsToAuditEvent: migrating =====================
-- add_column(:audit_events, :target_details, :text)
   -> 0.0009s
== 20200710120500 AddTargetDetailsToAuditEvent: migrated (0.0064s) ============

Rollback

== 20200710120500 AddTargetDetailsToAuditEvent: reverting =====================
-- remove_column(:audit_events, :target_details)
   -> 0.0006s
== 20200710120500 AddTargetDetailsToAuditEvent: reverted (0.0018s) ============

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Mentions #220325 (closed)

Edited by Peter Leitzen

Merge request reports