Skip to content

Remove temporary indexes on serialized objects cleanup

What does this MR do?

Remove temporary indexes used for serialized objects cleanup.

Relates to #220124 (closed)

Database Review

Migrate

rake db:migrate:up VERSION=20200710102846
== 20200710102846 DropIndexRubyObjectsInDetailsOnAuditEvents: migrating =======
-- transaction_open?()
   -> 0.0000s
-- indexes(:audit_events)
   -> 0.0037s
-- remove_index(:audit_events, {:algorithm=>:concurrently, :name=>"index_audit_events_on_ruby_object_in_details"})
   -> 0.0032s
== 20200710102846 DropIndexRubyObjectsInDetailsOnAuditEvents: migrated (0.0075s) 

Rollback

rake db:migrate:down VERSION=20200710102846
== 20200710102846 DropIndexRubyObjectsInDetailsOnAuditEvents: reverting =======
-- transaction_open?()
   -> 0.0001s
-- index_exists?(:audit_events, :id, {:where=>"details ~~ '%ruby/object%'", :name=>"index_audit_events_on_ruby_object_in_details", :algorithm=>:concurrently})
   -> 0.0038s
-- add_index(:audit_events, :id, {:where=>"details ~~ '%ruby/object%'", :name=>"index_audit_events_on_ruby_object_in_details", :algorithm=>:concurrently})
   -> 0.0075s
== 20200710102846 DropIndexRubyObjectsInDetailsOnAuditEvents: reverted (0.0123s) 

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tan Le

Merge request reports