Skip to content

Migrate '.fa-spinner' to '.spinner' within 'app/views/shared/boards'

What does this MR do?

Migrate fa-spinner to spinner / gl-loading-icon within 'app/views/shared/boards'"

Screenshots

app/views/shared/boards/_show.html.haml could only produce this result by hard coding the loading state. As the loader is not being used at all, I am removing it in this MR.

Before After
Screenshot_2020-07-09_at_17.34.23 Screenshot_2020-07-09_at_17.33.38

app/views/shared/boards/components/sidebar/_due_date.html.haml

Before After
Screenshot_2020-07-15_at_14.23.13 Screenshot_2020-07-15_at_14.23.46

app/views/shared/boards/components/sidebar/_labels.html.haml

Before After
Screenshot_2020-07-16_at_09.18.05 Screenshot_2020-07-16_at_09.16.50

app/views/shared/boards/components/sidebar/_milestone.html.haml

Before After
Screenshot_2020-07-16_at_09.20.09 Screenshot_2020-07-16_at_09.20.59

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related issue

#204741 (closed)

Edited by Brandon Labuschagne

Merge request reports