Skip to content

WIP: Show empty charts immediately

Miguel Rincon requested to merge 217758-show-loading-metrics into master

What does this MR do?

Removes the grouping of metrics and immediately shows empty charts as the metrics load.

  • Chart groups are not initially collapsed.
  • Contents of chart groups show all internal charts.
    • We still check if the chart is empty to show an empty illustration.

Technical Implementation

This MR mostly removes code: The "empty groups" components and the checks to collapse the groups are removed.

To Do:

  • Decide if removing the graph groups is needed.
  • Remove other unused code.

Screenshots

Please note that metrics are slow to load in my local, metrics should load faster when prometheus is closer to gitlab.

2020-07-09_17.22.49

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #217758 (closed)

Edited by Miguel Rincon

Merge request reports