WIP: Show empty charts immediately
What does this MR do?
Removes the grouping of metrics and immediately shows empty charts as the metrics load.
- Chart groups are not initially collapsed.
- Contents of chart groups show all internal charts.
- We still check if the chart is empty to show an empty illustration.
Technical Implementation
This MR mostly removes code: The "empty groups" components and the checks to collapse the groups are removed.
To Do:
- Decide if removing the graph groups is needed.
- Remove other unused code.
Screenshots
Please note that metrics are slow to load in my local, metrics should load faster when prometheus is closer to gitlab.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #217758 (closed)
Edited by Miguel Rincon