Skip to content

GitLab Next

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 39,511
    • Issues 39,511
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1,222
    • Merge requests 1,222
  • Requirements
    • Requirements
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
    • Value stream
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !36401

Merged
Created Jul 09, 2020 by Paul Slaughter@pslaughter🔴Maintainer

Step 1 - Remove IDE singleton store

  • Overview 14
  • Commits 4
  • Pipelines 4
  • Changes 24
  • POC MR
  • Step 1 - Remove IDE singleton store
  • Step 2 - Defer IDE gql client creation
  • Step 3 - Setup testURL in jest jsdom
  • Step 4 - Setup mock server for IDE integration spec
  • Step 5 - Add integration spec "user commits changes"

What does this MR do?

Singleton stores cause a number of problems, especially with the upcoming frontend_integration specs !36103 (closed) which cause registerModules to be called on the same instance twice.

This MR removes all references to the IDE Vuex store singleton and removes the export.

Screenshots

The only real reference to the singleton store was in Editor which setup some keyboard commands. It still works 🎉

Screen_Shot_2020-07-08_at_10.49.21_PM

References

  • POC MR !36103 (closed)
  • #208800 (closed)
Edited Sep 21, 2020 by Paul Slaughter
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 208800-step-2-1-remove-ide-singleton-store

Enable Gitpod?

To use Gitpod you must first enable the feature in the integrations section of your user preferences.

Cancel Enable Gitpod