Skip to content

Replace loading state with an icon, show dashboard skeleton earlier

Miguel Rincon requested to merge 217758-reduce-metrics-dashboard-loading into master

What does this MR do?

Part of #217758 (closed). Replaces the loading state with an icon and allows dashboard elements to be shown earlier.

  1. Does away with the loading global state in favor of a big loading icon.
  2. Shows the dashboard "structure" as soon as it is loaded, so collapsible groups appear early but collapsed

ToDo: Check on the kubernetes health dashboard. Checked!

Screenshots

Before

Previously we waited for any response from Prometheus to be loaded, so the empty state was displayed for longer.

1. loading dashboard (fast) 2. loading data (slow) 3. first data loaded (fast) 3. all data loaded
2020-07-09_15.30.45-9__dragged_ 2020-07-09_15.30.45-9__dragged_ 2020-07-09_15.15.14-81__dragged_ 2020-07-09_15.15.14-598__dragged_

After

Now we should the dashboard as soon as the skeleton is loaded, but the empty charts appear hidden, until some data is loaded.

1. loading dashboard (fast) 2. loading data (slow) 3. first data loaded (fast) 3. all data loaded
2020-07-09_15.15.14-38__dragged_ Screen_Shot_2020-07-14_at_5.36.08_PM Screen_Shot_2020-07-14_at_5.37.08_PM 2020-07-09_15.15.14-598__dragged_

Screencast (a bit slow, try to watch until the end)

2020-07-14_17.42.26

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports