Skip to content

Audit changes to project approval groups

Tan Le requested to merge 213603-audit-changes-to-approval-groups into master

What does this MR do?

Audit changes to approval group on project approval rule.

Relates to #213603 (closed)

Implementation approach

We wrap the rule.update in a ::Gitlab::Audit::Auditor which captures the initial audit context (i.e. author, scope, target, ip_address) object that are available at the time the operation is initiated.

Extra instrumentation is required in the interacted classes in the chain with Auditable mixin to record audit event to the Audit Event queue via ::Gitlab::Audit::EventQueue.

The EventQueue are stored in Thread via SafeRequestStore and then later extracted when we record an audit event in ::Gitlab::Audit::Auditor via AuditEventService.

Screenshots

Screen_Shot_2020-07-03_at_5.20.37_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tan Le

Merge request reports