Replace pencil icon calls with sprite_icon

What does this MR do?

This replaces the fa-icons icon('pencil', *) with sprite_icon('pencil', *) GitLab SVG icons.

Where and how to view / test?

Replace https://gdk.test:3443/ with your GDK root URL.

• Runners: https://gdk.test:3443/admin/runners
• Applications: https://gdk.test:3443/profile/applications
• UI: https://gdk.test:3443/help/ui
• Pipeline: https://gdk.test:3443/h5bp/html5-boilerplate/-/pipeline_schedules
• Profile: https://gdk.test:3443/root
• Members: https://gdk.test:3443/h5bp/html5-boilerplate/-/project_members
• Tags: https://gdk.test:3443/h5bp/html5-boilerplate/-/tags

Getting everything to some of these items to show can be tricky ❗, so here are some commands that may help. 💡

How to add an application:

Paste these lines in rails c

FactoryBot.definition_file_paths = [Rails.root.join('ee', 'spec', 'factories')]
FactoryBot.find_definitions

FactoryBot.create(:oauth_application, owner_id: nil, owner_type: nil)

How to add a runner:

Paste these lines in rails c

FactoryBot.definition_file_paths = [Rails.root.join('ee', 'spec', 'factories')]
FactoryBot.find_definitions

FactoryBot.create(:ci_runner)

How to display member overrides:

Apply this diff

diff --git a/app/views/shared/members/_member.html.haml b/app/views/shared/members/_member.html.haml
index dbb8a1198df..fdc68e263ed 100644
--- a/app/views/shared/members/_member.html.haml
+++ b/app/views/shared/members/_member.html.haml
@@ -125,7 +125,7 @@
                 = _("Delete")
               - unless force_mobile_view
                 = icon('trash', class: 'd-none d-sm-block')
-        = render_if_exists 'shared/members/ee/override_member_buttons', group: @group, member: member, user: user, action: :edit, can_override: member.can_override?
+        = render_if_exists 'shared/members/ee/override_member_buttons', group: member.group, member: member, user: user, action: :edit, can_override: true
       - else
         %span.member-access-text.user-access-role= member.human_access

Screenshots

Runners

Before	After

Applications

Before	After

Help / UI

Before	After

Pipeline Schedules

Before	After

Profile

Before	After

Members

Before	After

Tags

Before	After

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Closes #225951 (closed)