Add diffs_metadata.json to startup.js early requests
What does this MR do?
Moves the diffs_metada.json request to the startupjs "bundle" of early requests (see !34713 (merged)).
This means the request will be triggered as early as possible so that we save time after initialising the application.
Problems:
-
sometimes it's displaying: "No files" message before it populates the file tree — being addressed in !36446 (merged) -
are we rendering the tree as early as possible? -
(FIXED) it's requesting this, even if the target tab is "Overview" — maybe we should only request if the URL is for Changes tab
Screenshots
| Before (master) | After (this MR) |
|---|---|
 |
 |
| Kapture_2020-07-08_at_14.26.11 (Not the same run as the screenshot of the timings above) | startupjs_metadata_Kapture_2020-07-08_at_14.21.47 (Not the same run as the screenshot of the timings above) |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by André Luís