Add Rubocop rules for counters on large tables
requested to merge 220193-add-rubocop-rules-for-possible-dangerous-metrics-added-in-usage_ping-file into master
What does this MR do?
-
Add rule for not using one of the hardening methods for the metric added
With this MR we add a Rubocop rule for all metrics in usage_data.rb files that are based on ActiveRecord. If metrics are not using one of count or distinct_count hardening methods cop will fail
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related #220193 (closed)
Edited by Alina Mihaila