Create a blank PagerDuty webhook endpoint
What does this MR do?
Implements #227193 (closed)
Adds a blank (for now) webhook endpoint, which will be used to consume PagerDuty incident notifications.
Unfortunately, the PagerDuty webhook configuration allows specifying only a webhook URL. It doesn't allow to add any extra parameters such as headers, etc. GitLab needs to verify the request to check whether this request is authorized or not. GitLab should also provide the functionality to the users to regenerate compromised tokens.
The PagerDuty's suggested methods for securing your webhook, don't match with our requirements.
So we are thinking to receive a token via URL's query param.
We are going to provide a webhook URL to the users and ask them to use that URL to configure webhooks integration on the PagerDuty side.
The URL will look:
https://<gitlab-domain>/<namespace>/<project>/incident_management/pager_duty.json?token=<webhook-token>That's where we need approval from the security team.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team