Skip to content

Use stable sort in metrics dashboard sorter

Reuben Pereira requested to merge rp-use-stable-sort-in-sorter into master

What does this MR do?

Ruby's sort_by is not always a stable sort. When two keys are equal, the order of the corresponding elements is unpredictable.

This MR uses a stable sort in the metrics dashboard sorter stage, so that the order of panels and groups is not changed if their priorities/weights are equal.

Issue: #222812 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports