Skip to content

Reduce number of scanned commits for code intelligence

Igor Drozdov requested to merge id-fix-timeout-query into master

What does this MR do?

Related issue: #227039 (closed)

Sometimes https://gitlab.com/gitlab-com/gl-infra/triage-ops/-/blob/master/lib/scalability/triage.rb page fails due to the following request timing out:

image__1_

https://log.gprd.gitlab.net/app/kibana#/discover/doc/AW5F1e45qthdGjPJueGO/pubsub-rails-inf-gprd-003166?id=p1hLJHMBnC0FgnxTAlZc

The query with passed 10 commits turned out to be slow. We can change the number to 2 until we have an optimized query.

1 sha: https://explain.depesz.com/s/Unom

SELECT ci_job_artifacts.* FROM ci_job_artifacts INNER JOIN ci_builds ON ci_builds.id = ci_job_artifacts.job_id AND ci_builds.type = Ci::Build INNER JOIN ci_pipelines ON ci_pipelines.id = ci_builds.commit_id WHERE ci_job_artifacts.file_type = 15 AND ci_pipelines.sha=d63bc690cee4ecbfcfeab2eb73437bb1d0fd6f79 AND ci_pipelines.project_id = 9209370 ORDER BY ci_job_artifacts.id DESC LIMIT 1

2 shas: https://explain.depesz.com/s/Pp4j

SELECT ci_job_artifacts.* FROM ci_job_artifacts INNER JOIN ci_builds ON ci_builds.id = ci_job_artifacts.job_id AND ci_builds.type = Ci::Build INNER JOIN ci_pipelines ON ci_pipelines.id = ci_builds.commit_id WHERE ci_job_artifacts.file_type = 15 AND ci_pipelines.sha IN (d63bc690cee4ecbfcfeab2eb73437bb1d0fd6f79, f22559497722451b248af1b201d04ede6a9158ff) AND ci_pipelines.project_id = 9209370 ORDER BY ci_job_artifacts.id DESC LIMIT 1

10 shas: https://explain.depesz.com/s/Y3yf

SELECT ci_job_artifacts.* FROM ci_job_artifacts INNER JOIN ci_builds ON ci_builds.id = ci_job_artifacts.job_id AND ci_builds.type = Ci::Build INNER JOIN ci_pipelines ON ci_pipelines.id = ci_builds.commit_id WHERE ci_job_artifacts.file_type = 15 AND ci_pipelines.sha IN (d63bc690cee4ecbfcfeab2eb73437bb1d0fd6f79, 1b211f10c0b190d28258d5c870c080c4a3ec7186, 99e9e1bda801f296480dc42ca20090bb9cfbc9b5, bb31f6db7754d16148f431d17fb301273ed37951, 888c42c250b33f86c92776d6ca5d91697e7129d7, b2f6a184b5da0155a2bc86a62277e9114e250fec, 2cadbb84d118edef8141df204179b9dc2eba9705, 9c81378711729f027a6a284300d2918b101236d1, efc6bc52de42cb6791d3dfc905e90222eb122d9d, f22559497722451b248af1b201d04ede6a9158ff) AND ci_pipelines.project_id = 9209370 ORDER BY ci_job_artifacts.id DESC LIMIT 1
Edited by Igor Drozdov

Merge request reports