Skip to content

Geo Nodes - Title Spacing

Zack Cuddy requested to merge 225628-fix-geo-title-spacing into master

What does this MR do?

Closes #225628 (closed)

The Geo Node Title was using the flex box and spacing from the button to have the expected top and bottom spacing. However, when the button isn't there, it loses its bottom spacing due to a :last-child selector on .page-title that sets margin-bottom: 0;

This change adds .gl-mb-5\! to add the margin-bottom: 1rem (16px) that is expected to exist in all scenarios. I had to switch the syntax in the HAML file to support the \! part of the class.

Screenshots

w/ Button w/o Button
before w_Button_-_Old w_o_Button_-_Old
after w__Button_-_New w_o_Button_-_New

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #225628 (closed)

Edited by Zack Cuddy

Merge request reports