Geo Nodes - Title Spacing
What does this MR do?
Closes #225628 (closed)
The Geo Node Title was using the flex box and spacing from the button to have the expected top and bottom spacing. However, when the button isn't there, it loses its bottom spacing due to a :last-child
selector on .page-title
that sets margin-bottom: 0;
This change adds .gl-mb-5\!
to add the margin-bottom: 1rem (16px) that is expected to exist in all scenarios. I had to switch the syntax in the HAML file to support the \!
part of the class.
Screenshots
w/ Button | w/o Button | |
---|---|---|
before | ||
after |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #225628 (closed)
Edited by Zack Cuddy