Skip to content

Remove commit message 50 character soft limit

Drew Blessing requested to merge docs-dblessing-commit-message-soft-limit into master

What does this MR do?

Our commit message guidelines and Danger always mention that commit messages should ideally be less than 50 characters in length. I have seen mention of people disliking this in Slack in the past but I'm not sure if anyone has proposed we remove that guideline.

I personally have never ran into the 72 character limit, but I often exceed the 50 character limit. I can't think of a reason why we would prefer the message be less than 50 characters. In fact, needlessly shortening the commit message could make it more difficult to understand what the change was about.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Drew Blessing

Merge request reports