Add metrics for paused indexing Sidekiq queue size
What does this MR do?
Issue #217918 (closed)
- Add a new Prometheus metric for the index paused Sidekiq queue size. Following the example set by the existing metrics.
- Updated documentation
- Updated unit test
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.2
assigned to @terrichu
added 1 commit
- e77b2e0c - Add Prometheus Metrics for Index Pause Sidekiq Queue
1 Message This merge request adds or changes files that require a review from the Technical Writing team. Documentation review
The following files require a review from a technical writer:
doc/administration/monitoring/prometheus/gitlab_metrics.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Rubén Dávila ( @rdavila
) (UTC-5, 1 hours behind@terrichu
)Mayra Cabrera ( @mayra-cabrera
) (UTC-5, 1 hours behind@terrichu
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry as completed
added documentation label
added 1 commit
- 3a2ec721 - fixup! Add Prometheus Metrics for Index Pause Sidekiq Queue
added 18 commits
-
3a2ec721...8dd8e6ad - 16 commits from branch
master
- 028970d5 - Add Prometheus Metrics for Index Pause Sidekiq Queue
- 64f9ab20 - fixup! Add Prometheus Metrics for Index Pause Sidekiq Queue
-
3a2ec721...8dd8e6ad - 16 commits from branch
marked the checklist item Style guides as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Code review guidelines as completed
added 1 commit
- bd79433c - Add Prometheus Metrics for Index Pause Sidekiq Queue
marked the checklist item Documentation (if required) as completed
assigned to @axil and @mbergeron
- Resolved by Achilleas Pipinellis
@mbergeron are you available for a first review?
@axil I think this requires a documentation review as well, it's a small change but I wanted to be sure.
added workflowin review label and removed workflowin dev label
mentioned in commit gitlab-com/runbooks@589185d5
mentioned in merge request gitlab-com/runbooks!2476 (merged)
- Resolved by Terri Chu
@terrichu I'm glad you decided to do this, as I remember you talking about that just yesterday, so props to Results here.
I only have a single comment on the naming, feel free to apply it or not.
I approve this change.
unassigned @mbergeron
unassigned @axil
added Technical Writing label
added 1 commit
- 2ca03b10 - fixup! Add Prometheus Metrics for Index Pause Sidekiq Queue
marked as a Work In Progress from 2ca03b10
assigned to @mayra-cabrera
@mayra-cabrera are you available for a back end maintainer review?
mentioned in commit gitlab-com/runbooks@8595a2b0
enabled an automatic merge when the pipeline for f9236a3e succeeds
Thanks @terrichu! This LGTM, MWPS set
mentioned in commit fd57cd63
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in commit 9ab08d67
mentioned in merge request !36395 (merged)
mentioned in merge request !36473 (merged)
mentioned in commit gitlab-com/runbooks@9dcf3893
added typemaintenance label
added devopsdata stores label and removed devopssystems label