Build jql with search and labels params
What does this MR do?
Extend JqlBuilderService to handle a couple more params: search and labels
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.2
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Alina Mihaila ( @alinamihaila)Robert Speicher ( @rspeicher)If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by 🤖 GitLab Bot 🤖added 79 commits
-
e3bb5dfb...c19467f2 - 78 commits from branch
master - 67d40739 - Build jql with search and labels params
-
e3bb5dfb...c19467f2 - 78 commits from branch
@digitalmoksha mind taking a first review stab ?
assigned to @digitalmoksha
- Resolved by Markus Koller
@acroitor LGTM! Just had one question and several stupid nits. I'm off Friday, and my question is not really blocking, so I will go ahead an approve. You can have @arturoherrero double-check any changes if needed.
- Last reply by Brett Walker
unassigned @digitalmoksha
removed [deprecated] Accepting merge requests label
assigned to @digitalmoksha
added 299 commits
-
216d05aa...5b5246fa - 298 commits from branch
master - 48fd2b64 - Build jql with search and labels params
-
216d05aa...5b5246fa - 298 commits from branch
- Resolved by Alexandru Croitor
- Last reply by Alexandru Croitor
unassigned @digitalmoksha
assigned to @toupeira
unassigned @toupeira
assigned to @toupeira
added 269 commits
-
38784a71...1e691756 - 268 commits from branch
master - 529a2fcb - Build jql with search and labels params
-
38784a71...1e691756 - 268 commits from branch
unassigned @toupeira
assigned to @toupeira
mentioned in commit 92fdc71b
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !36369 (merged)
added 1 deleted label and removed devopscreate label
added devopsmanage label and removed 1 deleted label
