Raise error when non-dangling builds use YAML blob
What does this MR do?
amends Gitlab::Ci::Pipeline::Chain::Config::Content::Parameter to raise an exception when a non-dangling build (one that contributes to the last status of ref)
Why
to ensure that non-dangling builds do not use yaml blobs to construct their pipelines (accidentally or otherwise) as this could lead to redundant data being stored in the db.
Related Issue(s)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Philip Cunningham