Skip to content

Always Show Delete Button on Feature Flag Strategies

Jason Goodman requested to merge allow-no-strategies-in-ui into master

What does this MR do?

Always show the delete button on a feature flag strategy, even when there is only one strategy.

Previously, the UI enforced a flag having at least one strategy by hiding the delete button when there was only one strategy.

This also fixes the original bug described in the issue where sometimes the delete button would be displayed even when there was only a single strategy.

Issue: #223209 (closed)

Screenshots

Before:

Screen_Shot_2020-07-01_at_2.04.32_PM

After:

Screen_Shot_2020-07-01_at_2.03.22_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Groff Hennigh-Palermo

Merge request reports