Skip to content

Rename params to audit_params to stop overwriting

Robert Hunt requested to merge fix-group-events-pagination into master

What does this MR do?

This fixes an issue raised in #225471 (confidential) whereby we were previously setting params to the params allowed by the AuditLogFinder. This doesn't include page which meant further down page no longer existed and we did not paginate the results.

This MR changes the initial overwriting of params with setting a new variable called audit_params instead.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by GitLab Release Tools Bot

Merge request reports