Skip to content

Fix $border-radius-base SCSS value

Coung Ngo requested to merge cngo-fix-border-radius-base into master

What does this MR do?

This MR fixes the $border-radius-base SCSS value to 4px to align with Pajama's 8px spacing system as described in https://design.gitlab.com/layout/spacing and to match $gl-border-radius-base in gitlab-ui which is defined as 4px

Slack discussion: https://gitlab.slack.com/archives/CETG54GQ0/p1593162262093600

Screenshots

Before (dropdown uses 3px border radius): Screenshot_2020-07-01_at_1.09.14_pm

After (dropdown uses 4px border radius): Screenshot_2020-07-01_at_1.08.45_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by GitLab Release Tools Bot

Merge request reports