Skip to content

RUN AS-IF-FOSS Update "Allow to push" dropdown with Deploy Keys - FE

Etienne Baqué requested to merge 30769-keys-on-protected-branch-form into master

What does this MR do?

This MR is the frontend part for Deploy Keys in the Allowed to push dropdown, within the Protected branches Settings section. Main issue is here.

At the moment, users can be selected in addition to roles in EE only (more about this in docs). As we're introducing deploy keys in addition to roles in FOSS, we need to leverage that multi-select dropdown capability.

The changes this MR introduces are hidden behind the deploy_keys_on_protected_branches feature flag, as we'll have to merge other MRs (the backend one, documentation, etc). The feature flag YAML definition is here (created following these instructions).

Screenshots

Screenshot_from_2020-09-10_14-24-38

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Relates to #30769 (closed)

Edited by Etienne Baqué

Merge request reports