Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35,004
    • Issues 35,004
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,262
    • Merge Requests 1,262
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !35604

Merged
Opened Jun 30, 2020 by Adam Hegyi@ahegyiMaintainer6 of 6 tasks completed6/6 tasks

Support markdown in user's bio attribute

  • Overview 47
  • Commits 1
  • Pipelines 19
  • Changes 18

What does this MR do?

This MR adds support for markdown in the bio field on the user's profile.

The base of this MR is a community contribution which is inactive for quite some time: !20254 (closed)

Changes

In an earlier MR we've decided to move the bio attribute from the users table to user_details table. Now we're ready to ignore the users.bio column and use the user_details.bio. (Related MR: !27773 (merged))

Query to verify that the bios are identical in both tables:

select users.id, users.bio, user_details.bio from users inner join user_details on users.id=user_details.user_id where users.bio <> user_details.bio limit 1;
  • Store the html representation of the bio.
  • Render bio_html to the user popover.
  • Expose bio_html in our API.
  • Update the API docs.
  • Remap the validation error key for bio in the API: user_detail.bio => bio
  • Delegate bio and bio_html to user_detail

Screenshots

image

image

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • [-] Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • [-] Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited Jul 08, 2020 by Mayra Cabrera
Assignee
Assign to
Reviewer
Request review from
13.2
Milestone
13.2 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!35604
Source branch: add-markdown-support-in-bio

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.