Make related issues component more extendable
What does this MR do?
On the standalone vulnerabilities page, we're adding a related issues feature:
![]() |
that works almost exactly as it does on the Issues page. Rather that re-implement the feature, we are reusing the existing <related-issues-root>
component that's used on the Issues page, but the API behavior is slightly different between related issues on the Issues page, and the related issues on the vulnerability page.
This MR is some groundwork to make the <related-issues-root>
component more extendable so that it can support both APIs. For reference, this is the follow-up MR that uses the changes in this MR: !35625 (merged)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines - [-] Style guides
- [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Merge request reports
Activity
changed milestone to %13.2
added backstage [DEPRECATED] label
added database databasereview pending labels
4 Warnings 3778ba5d: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 9cb4e481: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 783880de: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 0ae7b92e: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 35598 "Make related issues component more extendable"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 35598 "Make related issues component more extendable"
If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend David O'Regan ( @oregand
) (UTC+1, 11 hours ahead@dftian
)Denys Mishunov ( @dmishunov
) (UTC+2, 12 hours ahead@dftian
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖marked as a Work In Progress from 795b64f2
removed database label
removed databasereview pending label
removed typefeature label
added typefeature label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a04c8e24 and 3778ba5d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.15 MB 4.15 MB - 0.0 % mainChunk 3.26 MB 3.26 MB - 0.0 %
Note: We do not have exact data for a04c8e24. So we have used data from: c5dfc913.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 6527b7a0 - Make related issues component more extendable
added 1 commit
- cd0555ed - Make related issues component more extendable
- Resolved by Coung Ngo
- Resolved by Coung Ngo
- Resolved by Miguel Rincon
added 1 commit
- b58d23cb - Make related issues component more extendable
added 1 commit
- 1aa033d5 - Make related issues component more extendable
added 1 commit
- 9c082ed2 - Make related issues component more extendable
- Resolved by Coung Ngo
- Resolved by Coung Ngo
- Resolved by Miguel Rincon
added 1 commit
- 693ba355 - Make related issues component more extendable
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
added 1 commit
- 96c2e2de - Make related issues component more extendable
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
added 1 commit
- 2509b39e - Make related issues component more extendable
added 1 commit
- 34934c4f - Make related issues component more extendable
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
@cngo Would you be able to take a look at this MR? I'm manually assigning it to you because I'd like someone who's a bit more familiar with the component to take a look at it, and you were the most recent person to touch some of the files. Please let me know, thanks!
assigned to @cngo
added 461 commits
-
34934c4f...8a471f73 - 459 commits from branch
master
- b25f7ec3 - Make related issues component more extendable
- a93847a2 - MR fixes
-
34934c4f...8a471f73 - 459 commits from branch
- Resolved by Coung Ngo
- Resolved by Miguel Rincon
added 1 commit
- 685bcd9d - Make related issues component more extendable
mentioned in issue #9424 (closed)
added 2 commits
added 346 commits
-
95347b1c...5ed0be0f - 343 commits from branch
master
- 218febf5 - Make related issues component more extendable
- f36f4d5b - MR fixes
- 9b2b9b7b - Rename showIssueTypeSelector to showCategorizedIssues
Toggle commit list-
95347b1c...5ed0be0f - 343 commits from branch
- Resolved by Miguel Rincon
@mrincon Would you be able to look at this MR?
added 43 commits
-
9b2b9b7b...896b2c2e - 40 commits from branch
master
- 49e215a1 - Make related issues component more extendable
- 32411d5c - MR fixes
- 39321e71 - Rename showIssueTypeSelector to showCategorizedIssues
Toggle commit list-
9b2b9b7b...896b2c2e - 40 commits from branch
assigned to @mrincon
unassigned @mrincon
added 749 commits
-
6093e46c...061db4a2 - 744 commits from branch
master
- b1b3e74a - Make related issues component more extendable
- 262ed8aa - Add MR fixes
- 3c12ae97 - Rename showIssueTypeSelector to showCategorizedIssues
- 74178031 - Add test for serviceClass property
- 9dd38cb2 - Remove custom service and revert parts of extendability
Toggle commit list-
6093e46c...061db4a2 - 744 commits from branch
added 1 commit
- 3889aba7 - Remove custom service and revert parts of extendability
added featureaddition label and removed backstage [DEPRECATED] label
added 1 commit
- 01487f42 - Remove custom service and revert parts of extendability
added 1 commit
- f12d521d - Remove custom service and revert parts of extendability
added 1 commit
- bf612026 - Remove custom service and revert parts of extendability
added 1 commit
- b1d95cfc - Remove custom service and revert parts of extendability
- Resolved by Lindsay Kerr
marked as a Work In Progress from ba8924bc
added 467 commits
-
8c1c8d40...fbac9974 - 459 commits from branch
master
- a3e18320 - Make related issues component more extendable
- f472cc2f - Add MR fixes
- 547a0ce6 - Rename showIssueTypeSelector to showCategorizedIssues
- 516a8bf5 - Add test for serviceClass property
- ec2b9978 - Remove custom service
- 631015a2 - Remove use of unionBy in store
- 42a5ad7b - Move store creation to created function
- f5b8564d - Use clear and add methods for pending references
Toggle commit list-
8c1c8d40...fbac9974 - 459 commits from branch
added 1 commit
- 7e7786ad - Use clear and add methods for pending references
added 1 commit
- ca6dab58 - Use clear and add methods for pending references
added 1 commit
- 0bd21a3c - Use clear and add methods for pending references
added 341 commits
-
0bd21a3c...a173fcce - 333 commits from branch
master
- 766bd01f - Make related issues component more extendable
- 375f525b - Add MR fixes
- eab249e3 - Rename showIssueTypeSelector to showCategorizedIssues
- 7ece7d17 - Add test for serviceClass property
- 0181afde - Remove custom service
- fc064481 - Remove use of unionBy in store
- bbabfa61 - Move store creation to created function
- f4dfd386 - Use clear and add methods for pending references
Toggle commit list-
0bd21a3c...a173fcce - 333 commits from branch
- Resolved by Miguel Rincon
@mrincon Would you mind taking a look at this MR again? As per our discussion, I reworked it to remove the custom service, and I updated the store so that it's more useful for the follow-up MR. Please let me know, thanks!
Edited by Daniel Tian
- Resolved by Miguel Rincon
added 252 commits
-
f4dfd386...3a9cc78f - 244 commits from branch
master
- 252fe8b4 - Make related issues component more extendable
- 0ae7b92e - Add MR fixes
- 783880de - Rename showIssueTypeSelector to showCategorizedIssues
- f0685f7f - Add test for serviceClass property
- 9cb4e481 - Remove custom service
- 70f9e6b1 - Remove use of unionBy in store
- e05cfa8c - Move store creation to created function
- 3778ba5d - Use clear and add methods for pending references
Toggle commit list-
f4dfd386...3a9cc78f - 244 commits from branch
enabled an automatic merge when the pipeline for 4c71bab0 succeeds
mentioned in commit 7940ba70
mentioned in merge request !35625 (merged)
added workflowstaging label and removed workflowin dev label
added workflowproduction label and removed workflowstaging label