Skip to content
Snippets Groups Projects

Make related issues component more extendable

Merged Daniel Tian requested to merge 9424-make-related-issues-component-more-extendable into master
All threads resolved!

What does this MR do?

On the standalone vulnerabilities page, we're adding a related issues feature:

Screenshot_from_2020-06-30_00-59-22

that works almost exactly as it does on the Issues page. Rather that re-implement the feature, we are reusing the existing <related-issues-root> component that's used on the Issues page, but the API behavior is slightly different between related issues on the Issues page, and the related issues on the vulnerability page.

This MR is some groundwork to make the <related-issues-root> component more extendable so that it can support both APIs. For reference, this is the follow-up MR that uses the changes in this MR: !35625 (merged)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Daniel Tian

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Tian
  • Daniel Tian
  • Daniel Tian added 1 commit

    added 1 commit

    • b58d23cb - Make related issues component more extendable

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • 1aa033d5 - Make related issues component more extendable

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • 9c082ed2 - Make related issues component more extendable

    Compare with previous version

  • Daniel Tian
  • Daniel Tian
  • Daniel Tian
  • Daniel Tian added 1 commit

    added 1 commit

    • 693ba355 - Make related issues component more extendable

    Compare with previous version

  • Daniel Tian
  • Daniel Tian
  • Daniel Tian
  • Daniel Tian
  • Daniel Tian
  • Daniel Tian added 1 commit

    added 1 commit

    • 96c2e2de - Make related issues component more extendable

    Compare with previous version

  • Daniel Tian
  • Daniel Tian
  • Daniel Tian added 1 commit

    added 1 commit

    • 2509b39e - Make related issues component more extendable

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • 34934c4f - Make related issues component more extendable

    Compare with previous version

  • Daniel Tian
    • Author Developer
      Resolved by Miguel Rincon

      @cngo Would you be able to take a look at this MR? I'm manually assigning it to you because I'd like someone who's a bit more familiar with the component to take a look at it, and you were the most recent person to touch some of the files. Please let me know, thanks!

  • assigned to @cngo

  • Daniel Tian changed the description

    changed the description

  • Coung Ngo assigned to @dftian and unassigned @cngo

    assigned to @dftian and unassigned @cngo

  • Daniel Tian added 461 commits

    added 461 commits

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Tian
  • Daniel Tian added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Tian
  • Daniel Tian changed the description

    changed the description

  • Daniel Tian assigned to @cngo and unassigned @dftian

    assigned to @cngo and unassigned @dftian

  • Daniel Tian added 1 commit

    added 1 commit

    • 685bcd9d - Make related issues component more extendable

    Compare with previous version

  • mentioned in issue #9424 (closed)

  • Coung Ngo approved this merge request

    approved this merge request

  • Coung Ngo assigned to @mrincon and unassigned @cngo

    assigned to @mrincon and unassigned @cngo

  • Coung Ngo assigned to @dftian and unassigned @mrincon

    assigned to @dftian and unassigned @mrincon

  • Daniel Tian added 2 commits

    added 2 commits

    Compare with previous version

  • Daniel Tian added 346 commits

    added 346 commits

    Compare with previous version

  • Daniel Tian assigned to @mrincon and unassigned @dftian

    assigned to @mrincon and unassigned @dftian

  • Daniel Tian added 43 commits

    added 43 commits

    Compare with previous version

  • Daniel Tian added 3 commits

    added 3 commits

    • 219d2eab - Add MR fixes
    • e1066fe1 - Rename showIssueTypeSelector to showCategorizedIssues
    • 6093e46c - Add test for serviceClass property

    Compare with previous version

  • Miguel Rincon assigned to @dftian and unassigned @mrincon

    assigned to @dftian and unassigned @mrincon

  • assigned to @mrincon

  • Daniel Tian added 749 commits

    added 749 commits

    • 6093e46c...061db4a2 - 744 commits from branch master
    • b1b3e74a - Make related issues component more extendable
    • 262ed8aa - Add MR fixes
    • 3c12ae97 - Rename showIssueTypeSelector to showCategorizedIssues
    • 74178031 - Add test for serviceClass property
    • 9dd38cb2 - Remove custom service and revert parts of extendability

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • 3889aba7 - Remove custom service and revert parts of extendability

    Compare with previous version

  • added featureaddition label and removed backstage [DEPRECATED] label

  • Daniel Tian added 1 commit

    added 1 commit

    • 01487f42 - Remove custom service and revert parts of extendability

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • f12d521d - Remove custom service and revert parts of extendability

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • bf612026 - Remove custom service and revert parts of extendability

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • b1d95cfc - Remove custom service and revert parts of extendability

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • be1a887a - Remove use of unionBy in store

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • 62a6e4b8 - Move store creation to created function

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • 93fe4190 - Move store creation to created function

    Compare with previous version

  • Daniel Tian added 1 commit
  • Daniel Tian marked as a Work In Progress from ba8924bc

    marked as a Work In Progress from ba8924bc

  • Daniel Tian added 1 commit
  • Daniel Tian added 467 commits

    added 467 commits

    • 8c1c8d40...fbac9974 - 459 commits from branch master
    • a3e18320 - Make related issues component more extendable
    • f472cc2f - Add MR fixes
    • 547a0ce6 - Rename showIssueTypeSelector to showCategorizedIssues
    • 516a8bf5 - Add test for serviceClass property
    • ec2b9978 - Remove custom service
    • 631015a2 - Remove use of unionBy in store
    • 42a5ad7b - Move store creation to created function
    • f5b8564d - Use clear and add methods for pending references

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • 7e7786ad - Use clear and add methods for pending references

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • ca6dab58 - Use clear and add methods for pending references

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • 0bd21a3c - Use clear and add methods for pending references

    Compare with previous version

  • Daniel Tian added 341 commits

    added 341 commits

    • 0bd21a3c...a173fcce - 333 commits from branch master
    • 766bd01f - Make related issues component more extendable
    • 375f525b - Add MR fixes
    • eab249e3 - Rename showIssueTypeSelector to showCategorizedIssues
    • 7ece7d17 - Add test for serviceClass property
    • 0181afde - Remove custom service
    • fc064481 - Remove use of unionBy in store
    • bbabfa61 - Move store creation to created function
    • f4dfd386 - Use clear and add methods for pending references

    Compare with previous version

  • Daniel Tian unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Daniel Tian assigned to @mrincon and unassigned @dftian

    assigned to @mrincon and unassigned @dftian

  • Miguel Rincon
  • Miguel Rincon approved this merge request

    approved this merge request

  • Miguel Rincon assigned to @dftian and unassigned @mrincon

    assigned to @dftian and unassigned @mrincon

  • Daniel Tian added 252 commits

    added 252 commits

    • f4dfd386...3a9cc78f - 244 commits from branch master
    • 252fe8b4 - Make related issues component more extendable
    • 0ae7b92e - Add MR fixes
    • 783880de - Rename showIssueTypeSelector to showCategorizedIssues
    • f0685f7f - Add test for serviceClass property
    • 9cb4e481 - Remove custom service
    • 70f9e6b1 - Remove use of unionBy in store
    • e05cfa8c - Move store creation to created function
    • 3778ba5d - Use clear and add methods for pending references

    Compare with previous version

  • Miguel Rincon resolved all threads

    resolved all threads

  • Miguel Rincon enabled an automatic merge when the pipeline for 4c71bab0 succeeds

    enabled an automatic merge when the pipeline for 4c71bab0 succeeds

  • Miguel Rincon assigned to @mrincon and unassigned @dftian

    assigned to @mrincon and unassigned @dftian

  • merged

  • Miguel Rincon mentioned in commit 7940ba70

    mentioned in commit 7940ba70

  • Daniel Tian mentioned in merge request !35625 (merged)

    mentioned in merge request !35625 (merged)

  • added workflowstaging label and removed workflowin dev label

  • Please register or sign in to reply
    Loading