Skip to content

Use plan and purchased storage for limit

Nicolas Dular requested to merge nicolasdular/expose-purchased-limits into master

What does this MR do?

Part of https://gitlab.com/gitlab-org/gitlab/-/issues/223207

It moves everything for storage limitation and alerts from CE to EE. The reasoning for that is that this feature will not be used in CE but only on Gitlab.com, which runs on EE. It is similar to CI Minutes limitations, which is also EE only.

Why was it CE initially? Initial idea was that the feature is also available in CE to lock down a namespace. This requirement changed recently.

Most importantly, this MR changes to use the limit from the namespace limits based on purchased storage and the plan instead of relying on the application settings. I'll remove the application setting in a follow-up MR.

The alerts and the check for the storage limit are still behind a feature flag. Therefore I have not created a separate changelog. The storageSizeLimit field on the namespace was not yet rolled out in a release, so there are no breaking changes from an API perspective.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolas Dular

Merge request reports