Skip to content

Move `finished_loading?` to `wait_for_requests`

Sanad Liaquat requested to merge qa-shl-wait-for-load-in-wait-for-spinner into master

What does this MR do?

Moves finished_loading? to wait_for_requests and removes now unnecessary finished_loading? calls.

This should make tests more stable and help mitigate issues such as #224446 (closed)

Also quarantine two tests due to: #225303 (closed)

Conformity

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Sanad Liaquat

Merge request reports