Gitlab integration form toggle
What does this MR do?
This is a WIP for the disable submit button issue. This form is currently written in Haml, which works by Rails converting it to HTML on the server side and displaying it to the user. Once the server is done generating the HTML, it cannot update anything in the browser, so the Save button can't dynamically change from grey/disabled to green/enabled based on user input unless we rewrite this form in Vue. This MR is the first step to rewriting the form in Vue. The submit button still won't be disabled until change as desired, since we have to move all the components to Vue for that to happen.
It will also close move button to the right issue
This MR will:
- Create a new Vue component for the form
- Move the toggle button to the new Vue component. (Other form inputs will be moved in follow-up MRs)
- Move buttons to the right, per related issue #219612 (closed)
- Update associated tests
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #219612 (closed)