Skip to content

Fix release assets link redirection

What does this MR do?

Fixes a bug which prevented the filepath alias from redirecting.

  • adds a prefix of / to the filepath
  • correctly prepends the required /downloads literal to the path
  • moves testing from controller to request specs to that the full Rails stack is executed and a false test positive is not received.

This will also resolve #232386 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Part of #217553 (closed)

Edited by Peter Leitzen

Merge request reports