Skip to content

Static Site Editor can’t be opened in projects belonging to a subgroup

Enrique Alcántara requested to merge fix-open-sse-on-subgroups into master

What does this MR do?

It fixes a bug that does not allow to open the Static Site Editor in a project located within a subgroup, for example: gitlab-com/subgroup/project-name.

How to reproduce it?

Open this URL: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/sse/master%2FREADME.md. It uses the Static Site Editor to edit the README.md file of a project within a subgroup. The Static Site Editor does not initialize.

Problem

namespace returns only parent namespace of the project without taking into consideration that it can belong to a group.

Solution

Return full path of the namespace with groups and subgroups.

Screenshots

Project that belongs to a subgroup Screenshot_2020-06-29_at_11.27.54

Without fix

Screenshot_2020-06-29_at_11.33.08

With the fix

Markdown file opened in Static Site Editor mode

Screenshot_2020-06-29_at_11.29.08

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vasilii Iakliushin

Merge request reports