Update Vulnerability when Finding is updated
What does this MR do?
Related to #214987 (closed)
This MR changes the logic responsible for creating Vulnerability objects in database. Introduced changes adds new behavior to update findings/scanners/identifiers/vulnerabilities when we are pipeline completes on default branch.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.2
2 Warnings 2b3b30dd: The commit subject length is acceptable, but please try to reduce it to 50 characters. For more information, take a look at our Commit message guidelines. 25c1b079: The commit subject length is acceptable, but please try to reduce it to 50 characters. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Mark Chao ( @lulalala
)Sean McGivern ( @smcgivern
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry as completed
mentioned in issue #214987 (closed)
assigned to @cam_swords and unassigned @mparuszewski
- Resolved by Sean McGivern
@cam_swords would you mind taking a first look?
- Resolved by Alan (Maciej) Paruszewski
- Resolved by Alan (Maciej) Paruszewski
- Resolved by Cameron Swords
- Resolved by Alan (Maciej) Paruszewski
- Resolved by Alan (Maciej) Paruszewski
- Resolved by Alan (Maciej) Paruszewski
assigned to @mparuszewski and unassigned @cam_swords
assigned to @cam_swords and unassigned @mparuszewski
assigned to @smcgivern and unassigned @cam_swords
- Resolved by Sean McGivern
- Resolved by Sean McGivern
- Resolved by Sean McGivern
assigned to @mparuszewski and unassigned @smcgivern
added 1 commit
- 2b3b30dd - Use ActiveRecord bang methods in vulnerability updates
assigned to @smcgivern and unassigned @mparuszewski
enabled an automatic merge when the pipeline for e5211c05 succeeds
mentioned in commit 5c54a28a
mentioned in issue gitlab-com/gl-infra/scalability#450