Skip to content

Add InstallScriptFactory, RegisterCommandBuilder and template files

Arthur de Lapertosa Lisboa requested to merge ciandt_dev/gitlab:add-install-register-runner-instructions into master

What does this MR do?

Adds the InstallScriptFactory, RegisterCommandBuilder and their tests. Their goal is to build instructions for installing and registering Runners. This MR also adds config and template files that are used for both classes.

This is the very first MR to address the issue and will be followed by more MRs addressing the controllers and views.

Are there points in the code the reviewer needs to double check?

  • I put the config files inside the same folder that contains the classes. Is this correct or should these config files be somewhere else?
  • We agreed during the initial discussions of this issue that Rails developers wouldn't be responsible to build the script template files. So I built only a sketch of how these files should look like. The only template file that is tested right now is the Linux one.

Does this MR meet the acceptance criteria?

  • Documentation created/updated - N/A
  • Added tests for this feature/bug
  • In case of conflicts with master - no conflicts

What are the relevant issue numbers?

#214587 (closed)

Edited by Elliot Rushton

Merge request reports