Skip to content

Replace fa icons with svg icons in Board modal

Martin Wortschack requested to merge mw-edit-board-modal-replace-fa-icons into master

What does this MR do?

This MR replaces font awesome icons in the boards modal with the SVG sprite.

Part of #224527 (closed), #224509 (closed) and #224534 (closed)

It replaces the following icons:

Fontawesome SVG sprite
fa-chevron-down chevron-down
fa-search search
fa-times close

Screenshots

Component Before After
Milestone Dropdown (fa-chevron, fa-search) milestone_dropdown_before milestone_dropdown_after
Milestone Dropdown (fa-times) milestone_clear_search_before  assignee_clear_search_after
Labels Dropdown (fa-chevron, fa-search) labels_dropdown_before labels_dropdown_after
Labels Dropdown (fa-times) labels_clear_search_before labels_clear_search_after
Assignee Dropdown (fa-chevron, fa-search) assignee_dropdown_before assignee_dropdown_after
Assignee Dropdown (fa-times) assignee_clear_search_before assignee_clear_search_after

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Martin Wortschack

Merge request reports