Skip to content

Preload commits markdown cache

Patrick Bajao requested to merge 209912-commits-markdown-cache-preload into master

What does this MR do?

This is for improving the performance of Projects::MergeRequestsController#commits action.

Prevents n+1 requests to Redis when getting the value from cache on render if the cache is warm.

Previously, it'll make an HMGET request to Redis per commit which can result to 100 requests when viewing the commits in a MR. Now, a single Redis pipeline is used via with_markdown_cache.

Utilizes the #preload_markdown_cache! introduced in !35312 (merged).

Improvements

Tested on local development environment with RAILS_PROFILE=true and cache is warm.

  • Before (average of 5 requests): 1.472014
  • After (average of 5 requests): 1.08282

That's around 26% improvement.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#209912

Edited by 🤖 GitLab Bot 🤖

Merge request reports