Skip to content

Fix Gitaly duration timings for remaining CommitService RPCs

Oswaldo Ferreira requested to merge osw-consume-streams-for-commit-service into master

What does this MR do?

For many Gitaly RPCs, previously the gitaly_duration_s log timings only accounted for the initial request/response time. We now measure the total time it takes to consume the streaming response for the following RPCs:

  1. ListFiles
  2. TreeEntry
  3. GetTreeEntries
  4. RawBlame
  5. GetCommitSignatures
  6. ListCommitsByRefName

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Oswaldo Ferreira

Merge request reports