Namespace storage purchase api
What does this MR do?
Following along with !34746 (merged) this MR is part of #223225 (closed).
You can see in this proposal how and when the API will be used: https://gitlab.com/gitlab-org/customers-gitlab-com/-/blob/staging/doc/proposal-storage-limit.md#scenario-5-paid-plan-with-or-without-extra-storage
NOTE: I've not added docs for the API since it will be used by customer portal only. We also don't expose the API for CI minutes yet in our docs.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.2
added 1 commit
- 5272bc49 - Add Namespace API to set additionally purchased storage
1 Warning 76178869: The commit subject length is acceptable, but please try to reduce it to 50 characters. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Hordur Freyr Yngvason ( @hfyngvason
)Bob Van Landuyt ( @reprazent
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added typefeature label
added devopsgrowth groupacquisition labels
added 1 commit
- 25ea8ba4 - Add Namespace API to set additionally purchased storage
marked the checklist item Changelog entry as completed
added 250 commits
-
25ea8ba4...bc0228c3 - 249 commits from branch
master
- 20a79d8e - Add Namespace API to set additionally purchased storage
-
25ea8ba4...bc0228c3 - 249 commits from branch
Hey @tyleramos, Do you mind reviewing this merge request, please? :) Thanks!
assigned to @tyleramos
- Resolved by Tyler Amos
- Resolved by Nicolas Dular
- Resolved by Nicolas Dular
- Resolved by Nicolas Dular
- Resolved by Nicolas Dular
- Resolved by Nicolas Dular
- Resolved by Tyler Amos
- Resolved by Nicolas Dular
- Resolved by Tyler Amos
@nicolasdular Nice job on this! Everything looks great from a code accuracy perspective AFAIK. I just had some minor suggestions mostly around testing which aren't really blockers for me.
unassigned @tyleramos
added 1 commit
- faa6c55d - Add Namespace API to set additionally purchased storage
added 1 commit
- e0446d80 - Add Namespace API to set additionally purchased storage
added 1 commit
- aa1e163f - Add Namespace API to set additionally purchased storage
added 105 commits
-
aa1e163f...2c122398 - 104 commits from branch
master
- f9dd258c - Add Namespace API to set additionally purchased storage
-
aa1e163f...2c122398 - 104 commits from branch
Hey @reprazent, Do you mind reviewing this merge request, please? :) Thanks!
assigned to @reprazent
- Resolved by Nicolas Dular
added 1 commit
- ac3e1bcc - Add Namespace API to set additionally purchased storage
- Resolved by Nicolas Dular
- Resolved by Nicolas Dular
- Resolved by Bob Van Landuyt
Thanks @nicolasdular, 2 thoughts.
unassigned @reprazent
assigned to @reprazent
unassigned @reprazent
added 172 commits
-
ac3e1bcc...9baace02 - 171 commits from branch
master
- 8784e9d5 - Add Namespace API to set additionally purchased storage
-
ac3e1bcc...9baace02 - 171 commits from branch
- Resolved by Nicolas Dular
assigned to @reprazent
- Resolved by Nicolas Dular
- Resolved by Bob Van Landuyt
Thanks @nicolasdular, that's what I had in mind
. Just 2 suggestions.
unassigned @reprazent
added 1 commit
- 76178869 - Add Namespace API to set additionally purchased storage
assigned to @reprazent
Thanks @nicolasdular, pipeline succeeded less than an hour ago, merging!
mentioned in commit 31669d75
mentioned in issue gitlab-com/gl-infra/scalability#450
mentioned in merge request !35561 (merged)