Move API::Runner and API::Runners to Ci namespace
What does this MR do?
Move Api::Runner
and Api::Runners
to the Api::Ci::Runners
/API::Ci::Runner
.
Many references to Ci
classes were changed to ::Ci::<model_name>
, it won't compile without that, it'll look for API::Ci::<model_name>
otherwise.
Part of #207480 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
2 Warnings This merge request is quite big (more than 1278 lines changed), please consider splitting it into multiple merge requests. 3d98d3f4: The commit subject length is acceptable, but please try to reduce it to 50 characters. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Michał Zając ( @quintasan
)Robert Speicher ( @rspeicher
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Hi @allison.browne,
Please add labels to your merge request, this helps triage community merge requests.
Thanks for your help!
You are welcome to help improve this comment.
added auto updated label
added devopsverify label
changed milestone to %13.2
added backstage [DEPRECATED] label
added database databasereview pending labels
removed database databasereview pending labels
added grouppipeline execution label
added 1 commit
- 83e43e35 - Move API::Runner and API::Runners to the Ci namespace
added 121 commits
-
83e43e35...1018045a - 119 commits from branch
master
- 7fa1c8fa - Move API::Runner and API::Runners to the Ci namespace
- 5f6f0445 - Automatic updates from rubocop
-
83e43e35...1018045a - 119 commits from branch
mentioned in issue #207480 (closed)
added backend label
added 1 commit
- 494f9ac9 - Move API::Runner and API::Runners to the Ci namespace
- Resolved by Bob Van Landuyt
@furkanayhan, can you please review this?
assigned to @furkanayhan
- Resolved by Allison Browne
unassigned @furkanayhan
- Resolved by Bob Van Landuyt
@reprazent, can you please review this as the backend maintainer? Thanks!
added 171 commits
-
56b1f8e8...b27ccc99 - 169 commits from branch
master
- aef429e4 - Move API::Runner and API::Runners to the Ci namespace
- 55577f60 - Align variables in pipeline
-
56b1f8e8...b27ccc99 - 169 commits from branch
assigned to @reprazent
- Resolved by Allison Browne
- Resolved by Allison Browne
- Resolved by Allison Browne
- Resolved by Allison Browne
- Resolved by Bob Van Landuyt
@allison.browne Thanks a lot! Only 1 nitpick worth doing, I think.
unassigned @reprazent
added 46 commits
-
55577f60...e15045dd - 43 commits from branch
master
- 3d98d3f4 - Move API::Runner and API::Runners to the Ci namespace
- 4724a33a - Align variables in pipeline
- 4d7db5d5 - Changes based on Code Review
Toggle commit list-
55577f60...e15045dd - 43 commits from branch
assigned to @reprazent
enabled an automatic merge when the pipeline for af5c5bb7 succeeds
Thanks @allison.browne
mentioned in commit b0d9c424
mentioned in issue gitlab-com/gl-infra/scalability#450
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label