Tag BuildFinishedWorker as using disk I/O (!35134) · Merge requests · GitLab.org / GitLab · GitLab

Sean McGivern requested to merge tag-build-finished-worker-as-using-nfs into master Jun 23, 2020

What does this MR do?

This tags the BuildFinishedWorker as using disk I/O, which we determined in gitlab-com/gl-infra/scalability#406 (closed).

By tagging it, we can then easily move this queue to happen on a different Sidekiq shard, and see if we see any further NFS reads from that shard: https://thanos-query.ops.gitlab.net/graph?g0.range_input=1h&g0.max_source_resolution=0s&g0.expr=sum%20by%20(operation%2C%20shard)%20(rate(node_mountstats_nfs_operations_requests_total%7Benv%3D%22gprd%22%2C%20type%3D%22sidekiq%22%2C%20operation%3D%22READ%22%7D%5B1m%5D))&g0.tab=0

If we don't see further NFS reads, it makes it easier to migrate this shard to Kubernetes (where there are no NFS mounts).

Edited Jun 23, 2020 by Sean McGivern