Skip to content

Count all epics on group show page

Jan Provaznik requested to merge epics_count_all into master

What does this MR do?

When showing epics count on group show page, we just count all epics in the group and its subgroups no matter if user can see them or not. This is consistent with showing epic's child counts (where accessibility check is skipped too) and we get rid of very expensive subgroup permission checking whenever a group show page is displayed.

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/222999#note_365855987

A related discussion where showing counts for subepics was discussed: !22284 (comment 270633407)

Also from security point of view I believe it's same as the scenario above and ACKed in !22284 (comment 271522152)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jan Provaznik

Merge request reports